openscd / open-scd

A substation configuration description editor for projects using SCL IEC 61850-6 Edition 2 or greater
https://openscd.github.io
Apache License 2.0
99 stars 31 forks source link

Update/create icons for the substation plugin #1229

Closed juancho0202 closed 6 months ago

juancho0202 commented 1 year ago

Is your feature request related to a problem? Please describe. As a user of OpenSCD, particularly of the Substation plugin, I want to have a clear way to differentiate in the screen at the root level which elements are Substations and which are Lines or Processes.

Describe the solution you'd like I would like to see the elements Substation, Line and Process to appear in the Substation plugin with an icon similar to the one that for example the PowerTransformer elements have:

image

Acceptance criteria

Background: Technical approach: Copy paste the SVG of the linked icon in this issue and put it in the package/open-scd/src/icons/icons.ts folder.

Sander3003 commented 1 year ago

Suggestion for icons: Line: https://www.flaticon.com/free-icon/power-line_125390 Process: https://www.flaticon.com/free-icon/process_2041633?term=process&page=1&position=25&origin=style&related_id=2041633

github-actions[bot] commented 1 year ago

Hello there,

Thank you for opening this issue! We appreciate your interest in our project. However, it seems that this issue hasn't had any activity for a while. To ensure that our issue tracker remains organized and efficient, we occasionally review and address stale issues.

If you believe this issue is still relevant and requires attention, please provide any additional context, updates, or details that might help us understand the problem better. Feel free to continue the conversation here.

If the issue is no longer relevant, you can simply close it. If you're uncertain, you can always reopen it later.

Remember, our project thrives on community contributions, and your input matters. We're here to collaborate and improve. Thank you for being part of this journey!

Sander3003 commented 1 year ago

The issue is still relevant, it can be fixed one day!

juancho0202 commented 10 months ago

Substation icon: https://www.flaticon.com/free-icon/electric-factory_4882901?term=substation&page=1&position=2&origin=search&related_id=4882901

juancho0202 commented 10 months ago

Technical approach: Copy paste the SVG of the linked icon in this issue and put it in the package/open-scd/src/icons/icons.ts file.

Sander3003 commented 8 months ago

https://github.com/ca-d/oscd-designer/blob/main/icons.ts can be a source as well. This is in investigation.

Sander3003 commented 8 months ago

Investigation from Pascal: https://codepen.io/pascalwilbrink/full/gOEWKmy

Sander3003 commented 8 months ago

Powertransformer is theire: image

Sander3003 commented 8 months ago

Winding is missing: image

Sander3003 commented 8 months ago

Requests:

Reuse the substation icon already used in OpenSCD (no design needed)

Make a material design like icon's based on the following examples:

Bay: image

Voltage level: image

Winding: image

Proces: https://www.flaticon.com/free-icon/process_2041633?term=process&page=1&position=25&origin=style&related_id=2041633

Line: image

Source for some of the icons: https://github.com/ca-d/oscd-designer/blob/main/icons.ts

JakobVogelsang commented 8 months ago

Jan was so kind and offered to also take a look at our primary apparatus icons that are:

Circuit breaker:

grafik

disconnector:

grafik

Earth switch:

grafik

Current transformer:

grafik

Voltage transformer:

grafik

General primary apparatus: grafik (I think this is material already but maybe Jan can think of a better one)

JanDietvorst commented 7 months ago

Hi all, Here are all the icons as shown above. I discussed everything with Jakob. If there is a need for more icons in the future please let me know. I'm happy to help! J

IC_Bay 24px

IC_Bay 24px

IC_Bay 48px

IC_Bay 48px

IC_Circuitbraker 24px

IC_Circuitbraker 24px

IC_Circuitbraker 48px

IC_Circuitbraker 48px

IC_Current transformer 24px

IC_Current transformer 24px

IC_Current transformer 48px

IC_Current transformer 48px

IC_Disconnector 24px

IC_Disconnector 24px

IC_Disconnector 48px

IC_Disconnector 48px

IC_Earth switch 24px

IC_Earth switch 24px

IC_Earth switch 48px

IC_Earth switch 48px

IC_General primary aparatus 2C 24px

IC_General primary aparatus 2C 24px

IC_General primary aparatus 2C 48px

IC_General primary aparatus 2C 48px

IC_General primary aparatus 3C 24px

IC_General primary aparatus 3C 24px

IC_General primary aparatus 3C 48px

IC_General primary aparatus 3C 48px

IC_Line 24px

IC_Line 24px

IC_Line 48px

IC_Line 48px

IC_Power transformer 24px

IC_Power transformer 24px

IC_Power transformer 48px

IC_Power transformer 48px

IC_Powerline 24px

IC_Powerline 24px

IC_Powerline 48px

IC_Powerline 48px

IC_Process 24px

IC_Process 24px

IC_Process 48px

IC_Process 48px

IC_Substation 24px

IC_Substation 24px

IC_Substation 48px

IC_Substation 48px

IC_Voltage level 24px

IC_Voltage level 24px

IC_Voltage level 48px

IC_Voltage level 48px

IC_Voltage transformer 24px

IC_Voltage transformer 24px

IC_Voltage transformer 48px

IC_Voltage transformer 48px

IC_Winding 24px

IC_Winding 24px

IC_Winding 48px

IC_Winding 48px
Sander3003 commented 7 months ago

Thanks @JanDietvorst!

juancho0202 commented 6 months ago

Hey @JanDietvorst we would appreciate if you added the name of each icon and a short description of how they are meant to be used. Thanks!

JanDietvorst commented 6 months ago

Hi @juancho0202 i've added the svg's of the icons above. The name of each svg contains the meaning of the icon. Also the use is in the name 24 or 48px.

juancho0202 commented 6 months ago

@Sander3003 we have decided during refinement that we will not use the IC_Powerline icon for the Line element but we'll stick with the IC_Line one. Also from the two options for general equipment we have chosen the 2C option.