search

openscd / open-scd

A substation configuration description editor for projects using SCL IEC 61850-6 Edition 2 or greater
https://openscd.github.io
Apache License 2.0
99 stars 31 forks source link

Subscriber supervision instantiation bypasses Action API #1231

Open danyill opened 1 year ago

danyill commented 1 year ago

Describe the bug

Currently, the subscriber supervision instantiation bypasses the Action API when a Val element exists.

This means that undo/redo is lost and likely other side effects.

https://github.com/openscd/open-scd/blob/03632e21957a51b3ca6db6e7169ca88bb1e59a12/src/editors/subscription/foundation.ts#L356-L372

To Reproduce

Found during code examination.

Most likely can be reproduced by having an LGOS/LSVS LN with an existing Val element with an empty string being available for a subscription.

Additional context

This will be at least partially resolved for later binding in the oscd-subscriber-later-binding project but this will not fix the message and data plugins

Also

See the linked issue below, the selection of the Val element is also incorrect, it needs to be qualified by the DOI and the DAI.

github-actions[bot] commented 1 year ago

Hello there,

Thank you for opening this issue! We appreciate your interest in our project. However, it seems that this issue hasn't had any activity for a while. To ensure that our issue tracker remains organized and efficient, we occasionally review and address stale issues.

If you believe this issue is still relevant and requires attention, please provide any additional context, updates, or details that might help us understand the problem better. Feel free to continue the conversation here.

If the issue is no longer relevant, you can simply close it. If you're uncertain, you can always reopen it later.

Remember, our project thrives on community contributions, and your input matters. We're here to collaborate and improve. Thank you for being part of this journey!

danyill commented 1 year ago

Still relevant and requires attention but addressed in my updated subscriber plugin.