openscd / open-scd

A substation configuration description editor for projects using SCL IEC 61850-6 Edition 2 or greater
https://openscd.github.io
Apache License 2.0
97 stars 31 forks source link

Support ldName attribute #1326

Closed BurTah00 closed 8 months ago

BurTah00 commented 11 months ago

As a user of OpenSCD I want to use functional naming in order to create vendor independent SCD files consisting virtual IEDs without referring to IED name+LDinst attributes.

JakobVogelsang commented 11 months ago

Hi @BurTah00, there were multiple users interested in this support. It is a bit hard to fully answer what this in particular means. I think it strongly depends on when you are touching the element LDevice. Just from the top of my head it could be:

  1. Edit it right at the end before exporting by simply editing, the element LDevice. And could add a field name next to inst.
  2. Create a virtual IED to be shared with vendors. In that case, we need to change the way the plugin Virtual IED works.
BurTah00 commented 11 months ago

Well, I can only foresee a stepwise approach for implementation. For a low hanging fruit : 1. "edit it right at the end before exporting" image A SIEMENS like UI with "name" field is fine enough.

In the long run, there is definetely a need for 2. to create ISD (SSD) like files. But 1. is urgent to have for the moment :)

JakobVogelsang commented 11 months ago

Top let's do that.

Sander3003 commented 11 months ago

@DavoodSooran

DavoodSooran commented 9 months ago

Is your feature request related to a problem? Please describe.

As a 104 Engineer, I aim to modify the ldName associated with a particular LDevice. Presently, CoMPAS lacks support for this functionality, necessitating the inclusion of ldName configuration within the tool. Below outlines the steps involved in configuring and altering the ldName.

It's important to note that we don't want users to modify the inst of an LDevice. Changing the ldInst might create inconsistencies across the entire SCD file. Only modifications to ldName are permitted.

Describe the solution you'd like

After uploading your selected SCD file, the IED module will display the supported LDevices within an IED. Clicking on the Filter icon in the Filter section will reveal a list of all available IEDs in the SCD. From this list, you can select the appropriate IED as per your needs. Once selected, all the LDevices within that chosen IED will be listed in the IED module.

IED select

After selecting the desired IED, the IED module will display all the listed LDevices within that IED. At this point, we aim to modify the ldName of these LDevices. To do so, we require an Edit icon, similar to the one shown in the picture below. However, this particular option is currently not visible or selectable within CoMPAS' IED module.

LdName edit button

Clicking on the Edit icon situated on the right side of each LDevice section will prompt a new window to appear, enabling you to modify the ldName and Description. It's important to note that we do not permit users to alter the ldInst of an LDevice, as this could cause inconsistencies throughout the entire SCD file. Therefore, the ldInst section is grayed out and disabled to prevent modifications. Only the ldName can be changed.

Once the ldName and Description sections are modified, the changes can be saved, and they will be applied to the SCD file. Clicking on the Edit icon located at the top right side of the dialog box is expected to display the selected LDevice on the SCD code page, as shown in the image below:

SCD code

It's crucial to note that the availability of the dialog box is contingent upon the presence of the ConfLdName service within the services section of the SCD file. In the event that this service is absent, users should still have access to the dialog box. However, in this scenario, all parameters will be displayed in a grayed-out and disabled state, preventing any modifications. This limited functionality allows users only to view the current ldName and ldInst without the ability to make changes. An example of the services section from an SCD file is displayed below.

image

DavoodSooran commented 9 months ago

@Stef3st I realized I made an error while defining this issue. I've already rectified the problem in the images. The issue was within the Edit Logical Device dialog box, where I suggested displaying the ldName and desc. However, as per the standard, the LDevice instance will be denoted as inst in the SCD file. Hence, including what I requested, ldInst, in the Edit Logical Device dialog box would introduce an additional attribute in the SCD file, resembling the following:

image

Therefore, ldInst isn't the correct one. In the images provided with the issue, I've already made the change to inst. By incorporating this inst in the Edit Logical Device dialog box, we can avoid an additional incorrect LDevice instance in the SCD file. The accurate code in the SCD file should now reflect as follows:

image

Stef3st commented 9 months ago

@DavoodSooran no worries, I already saw that ldInst was suppose to be inst so its already correct in the PR and is set to inst in the SCL 🙂 I do, however, call it ldInst in the dialog because I thought that was the desired name. Do you suggest to change the field title from ldInst to inst in the dialog aswell?

DavoodSooran commented 9 months ago

@DavoodSooran no worries, I already saw that ldInst was suppose to be inst so its already correct in the PR and is set to inst in the SCL 🙂 I do, however, call it ldInst in the dialog because I thought that was the desired name. Do you suggest to change the field title from ldInst to inst in the dialog aswell?

I believe we can keep the ldInst in the dialog box as long as it doesn't alter the SCD file. :-)