ADR: Don't rely on third party dependencies for the filtered list

openscd / oscd-filtered-list

Apache License 2.0

0 stars 0 forks source link

ADR: Don't rely on third party dependencies for the filtered list #13

Closed Stef3st closed 1 year ago

Stef3st commented 1 year ago

closes #12

tamasrusz commented 1 year ago

A few things I noticed:

the document is currently not in a doc/adr/ folder
the document's file name is not in the format of xxxx-title (e.g.: 0001-third-party-implementation.md

tamasrusz commented 1 year ago

I think you nicely described the situation. Only the title is a bit confusing for me. As far as I've understood, the new component still depends on the the mwc-list and therefore the users of oscd-filtered-list too. The main changes is that they no longer have to directly install and import mwc-list.

So my suggestion for the title would be something along lines:

"Encapsulate mwc-list instead of extending it"

Stef3st commented 1 year ago

I think you nicely described the situation. Only the title is a bit confusing for me. As far as I've understood, the new component still depends on the the mwc-list and therefore the users of oscd-filtered-list too. The main changes is that they no longer have to directly install and import mwc-list.

So my suggestion for the title would be something along lines:

"Encapsulate mwc-list instead of extending it"

Thank you, Ill change the title to something less confusing!

Sander3003 commented 1 year ago

Feel free to share the new ADR in the Slack channel! It will help to get accepted