search

openscholar / starterkit

starterkit
4 stars 22 forks source link

starterkit.flav has incorrect JS path #1

Open ebiewener opened 10 years ago

ebiewener commented 10 years ago

The starterkit.flav file provides the following path for including the example JS file:

scripts[] = starterkit.js

Shouldn't this be:

scripts[] = js/starterkit.js

baisong commented 10 years ago

PR? You can do it all from the browser

ebiewener commented 10 years ago

I'm not looking to participate in Github at that level :)

Eric Biewener Project Manager

Harvard Web Publishing - HUIT P 617-495-4181 125 Mt. Auburn St, 2nd Floor Cambridge, MA 02138

From: oren notifications@github.com<mailto:notifications@github.com> Reply-To: openscholar/starterkit reply@reply.github.com<mailto:reply@reply.github.com> Date: Friday, April 4, 2014 at 10:54 AM To: openscholar/starterkit starterkit@noreply.github.com<mailto:starterkit@noreply.github.com> Cc: Eric Biewener eric_biewener@harvard.edu<mailto:eric_biewener@harvard.edu> Subject: Re: [starterkit] starterkit.flav has incorrect JS path (#1)

PR? You can do it all from the browserhttps://github.com/blog/1557-github-flow-in-the-browser

Reply to this email directly or view it on GitHubhttps://github.com/openscholar/starterkit/issues/1#issuecomment-39573475.

dancabral commented 10 years ago

correct. the js path for the starterkit.js should be js/starterkit.js. looking over the starterkit structure now. will update it shortly.

dancabral commented 10 years ago

custom flavor js path reference is fixed in starterkit.flav

adriannacrowell commented 10 years ago

I did everything as listed in the directions (README), but when I zip the file and try to upload, Open Scholar keeps saying the "module" is missing and does not work!!! The module is listed as cleanblue and I am using that current theme. What is going on!

:The theme you uploaded is not valid. module directive missing.

dancabral commented 10 years ago

Sorry amarie004. I'll take a look at this tomorrow and write back then. Thanks.

adriannacrowell commented 10 years ago

Awesome! Thank you so much.

On Oct 2, 2014, at 3:05 PM, dancabral notifications@github.com wrote:

Sorry amarie004. I'll take at this tomorrow and write back then. Thanks.

— Reply to this email directly or view it on GitHub.

dancabral commented 10 years ago

@amarie004 when I've experienced that error (more than a couple of times) its been due to extra/bad characters in the .flav file. So you've downloaded the starterkit package. Then where did you edit (what did you use) the .flav file? A couple of times I was pretty sure I had a clean file, only to find out there were invisible characters. You can use a plain txt editor. Please let us know how it goes. Thanks.