search

opensciencegrid / stashcp

Apache License 2.0
0 stars 10 forks source link

Accum errors #13

Closed djw8605 closed 2 years ago

djw8605 commented 2 years ago

Gives errors like:

$ ./stashcp /osgconnect/public/dweitzel/doesnotexist ./
ERROR[2021-10-11T20:17:46-05:00] All methods failed! Unable to download file. 
ERROR[2021-10-11T20:17:46-05:00] Failed to download from http://osg-kansas-city-stashcache.nrp.internet2.edu:8000/osgconnect/public/dweitzel/doesnotexist + proxy=true: server returned 404 Not Found;Failed to download from http://osg-kansas-city-stashcache.nrp.internet2.edu:8000/osgconnect/public/dweitzel/doesnotexist + proxy=false: server returned 404 Not Found;Failed to download from http://stash-cache.osg.chtc.io:8000/osgconnect/public/dweitzel/doesnotexist + proxy=true: server returned 404 Not Found;Failed to download from http://stash-cache.osg.chtc.io:8000/osgconnect/public/dweitzel/doesnotexist + proxy=false: server returned 404 Not Found;Failed to download from http://osg-chicago-stashcache.nrp.internet2.edu:8000/osgconnect/public/dweitzel/doesnotexist + proxy=true: server returned 404 Not Found;Failed to download from http://osg-chicago-stashcache.nrp.internet2.edu:8000/osgconnect/public/dweitzel/doesnotexist + proxy=false: server returned 404 Not Found;

Also, sorry about no word wrapping.

matyasselmeci commented 2 years ago

Can you add newlines perhaps?

djw8605 commented 2 years ago

Done

matyasselmeci commented 2 years ago

I meant newlines between the error messages

djw8605 commented 2 years ago

I don't know how the condor file transfer plugin error output works. Is it just the last line? This is mostly just for the file transfer plugin error handling.

matyasselmeci commented 2 years ago

Ah, if this is for a file transfer plugin then never mind, one line is fine.

djw8605 commented 2 years ago

It’s also used in other tests, so it’s not just for this one test.

On Oct 12, 2021, at 5:33 PM, Matyas Selmeci @.***> wrote:

 @matyasselmeci approved this pull request.

LGTM although I'm not a big fan of bringing in an external library for one assert statement.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

bbockelm commented 2 years ago

FWIW - the file transfer plugin takes the last 1Kb of output and replaces new lines with ;