search

opensciencegrid / xrootd-lcmaps

Integration between Xrootd and LCMAPS.
Apache License 2.0
4 stars 11 forks source link

No auth warning #44

Closed efajardo closed 4 years ago

efajardo commented 4 years ago

@ddavila0 thanks I applied your changes and also the change requeste in PR-45 so maybe we can close that one.

bbockelm commented 4 years ago

@efajardo - here's my thinking:

  1. Only do warning when conflicting options are set: that is, if a LCMAPS config file is provided and no-authz is set, then warn the user. As the two config variables conflict, they likely don't mean to do this.
  2. When no-authz is set (and nothing conflicts), then we should have an info-level message saying something like "The no-authz option is set; LCMAPS will not be loaded or invoked."
bbockelm commented 4 years ago

It appears that indention is messed up. Can you see if perhaps your editor is mixing tabs and spaces?

Is it possible to separate out the switch to the Xrootd base version to 4.12?

efajardo commented 4 years ago

@bbockelm and @brianhlin I fixed all the problems can you approve. I will create a separate PR for 4.12