search

opensciencemap / vtm

a vector-tile map library written in java - running on android, desktop and within the browser
GNU Lesser General Public License v3.0
238 stars 176 forks source link

3d buildings and min_height tag #134

Closed cmarchi closed 9 years ago

cmarchi commented 9 years ago

I've just discovered opensciencemap and it's great! thanks for your work. While experimenting, I think I found a problem with 3d building gneration somehow related to the min_height tag. Here you can see two examples of buildings I've made that contains this tag:

http://www.opensciencemap.org/map/#&scale=18&rot=-1&tilt=51&lat=35.73&lon=139.718 http://demo.f4map.com/#lat=35.7307212&lon=139.7183987&zoom=18&camera.theta=50.157&camera.phi=-7.448 http://www.opensciencemap.org/map/#&scale=18&rot=1&tilt=62&lat=35.684&lon=139.686 http://demo.f4map.com/#lat=35.6850440&lon=139.6870386&zoom=18&camera.theta=62.762&camera.phi=2.005

In f4map they are correctly displayed while in opensciencemap not. Thanks for any help.

hjanetzek commented 9 years ago

Thanks for the feedback!

This one was easy to fix by just commenting out some code that should have only clipped invisible parts for optimization.. :)

I'm aware that our implementation is not fully S3DB conform yet - so far it's the result of a long hack weekend

cmarchi commented 9 years ago

Thank you very much for the fix!