openscilab / pymilo

PyMilo: Python for ML I/O
MIT License
148 stars 5 forks source link

Feature:: Preprocessing models #104

Closed AHReccese closed 5 months ago

AHReccese commented 6 months ago

Reference Issues/PRs

88

What does this implement/fix? Explain your changes.

In this PR following changes are applied:

Following preprocessing classes are implemented and tested. In front of each module, I wrote the problem we faced when adding it to Pymilo.
Tests for the following preprocessing classes are tested:

Any other comments?

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 82.66667% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 85.41%. Comparing base (06716ac) to head (5211ad6). Report is 15 commits behind head on dev.

:exclamation: Current head 5211ad6 differs from pull request most recent head 3d7dd6c

Please upload reports for the commit 3d7dd6c to get more accurate results.

Files Patch % Lines
...transporters/general_data_structure_transporter.py 64.29% 3 Missing and 2 partials :warning:
pymilo/pymilo_param.py 66.67% 4 Missing :warning:
pymilo/transporters/preprocessing_transporter.py 89.75% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #104 +/- ## ========================================== - Coverage 87.40% 85.41% -1.99% ========================================== Files 31 36 +5 Lines 1142 1774 +632 Branches 201 388 +187 ========================================== + Hits 998 1515 +517 - Misses 90 163 +73 - Partials 54 96 +42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AHReccese commented 6 months ago

@sadrasabouri Dear Sadra, please review my updates.

AHReccese commented 6 months ago

NaN-type support is also added. Also please listen to voices in telegram, I've explained what I've done to handle these cases:

@sadrasabouri

AHReccese commented 6 months ago

We will address the coverage issue in a separate PR. I will enhance code coverage to over 90%.

AHReccese commented 6 months ago

Dear Sadra, I've applied your suggestions, thank you so much for your detailed review. I really appreciate it. Please re-review again.

sepandhaghighi commented 6 months ago

LGTM now, @sepandhaghighi can you please review it?

I will review this pull request within the next 48 hours. 💯

AHReccese commented 5 months ago

@sadrasabouri Thank you Sadra for applying Sepand's comments, I went through them one by one and it is great! @sepandhaghighi waiting for your final review sir.