Closed AHReccese closed 5 months ago
Attention: Patch coverage is 82.66667%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 85.41%. Comparing base (
06716ac
) to head (5211ad6
). Report is 15 commits behind head on dev.:exclamation: Current head 5211ad6 differs from pull request most recent head 3d7dd6c
Please upload reports for the commit 3d7dd6c to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@sadrasabouri Dear Sadra, please review my updates.
NaN-type support is also added. Also please listen to voices in telegram, I've explained what I've done to handle these cases:
@sadrasabouri
We will address the coverage issue in a separate PR. I will enhance code coverage to over 90%.
Dear Sadra, I've applied your suggestions, thank you so much for your detailed review. I really appreciate it. Please re-review again.
LGTM now, @sepandhaghighi can you please review it?
I will review this pull request within the next 48 hours. 💯
@sadrasabouri Thank you Sadra for applying Sepand's comments, I went through them one by one and it is great! @sepandhaghighi waiting for your final review sir.
Reference Issues/PRs
88
What does this implement/fix? Explain your changes.
In this PR following changes are applied:
Following preprocessing classes are implemented and tested. In front of each module, I wrote the problem we faced when adding it to Pymilo.
array([[..],...,[...]])
andarray([array([..]),...,array([...])])
encoded_missing_value
field could beNaN
which I think can make JSON file unparsable)StandardScaler
transportation - transportation loop)scipy.interpolate.BSpline
)sklearn.__version__ > 1.3
)Tests for the following preprocessing classes are tested:
Any other comments?