search

openscilab / pymilo

PyMilo: Python for ML I/O
MIT License
148 stars 5 forks source link

minor refactorings in naming conventions #116

Closed AHReccese closed 3 months ago

AHReccese commented 3 months ago

Reference Issues/PRs

Minor Enhancements on naming convension

What does this implement/fix? Explain your changes.

Any other comments?

AHReccese commented 3 months ago

Extremely hard?! weird! @sadrasabouri

sadrasabouri commented 3 months ago

Extremely hard?! weird! @sadrasabouri

Yes. BTW, you can merge it anytime. I just stopped merging it due to the several opened PRs originating from the same branch. Please merge them cautiously.

AHReccese commented 3 months ago

Each PR should definitely get reviewed carefully without relying on anything else. If it's hard, we can have a meeting to clarify the details. Let me know your time availability. @sadrasabouri

AHReccese commented 3 months ago

I've sent you a video regarding this PR, I hope it clarifies it well. Let me know if you have any other questions. @sadrasabouri

AHReccese commented 3 months ago

Extremely hard?! weird! @sadrasabouri

Yes. BTW, you can merge it anytime. I just stopped merging it due to the several opened PRs originating from the same branch. Please merge them cautiously.

Don't worry, after you completely finish your review, I will take care of merging.

sadrasabouri commented 3 months ago

I accidentally merged it, I opened a revert branch but you can remove that branch and update other PRs with current dev.

AHReccese commented 3 months ago

Don't worry pal, We good. @sadrasabouri