search

openscilab / pymilo

PyMilo: Python for ML I/O
MIT License
148 stars 5 forks source link

FeatureAgglomeration addition #63

Closed AHReccese closed 10 months ago

AHReccese commented 11 months ago

Reference Issues/PRs

17

What does this implement/fix? Explain your changes.

add support for FeatureAgglomeration model add basic function transporter

Any other comments?

codecov[bot] commented 11 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f3855f5) 85.91% compared to head (14d58b3) 86.14%.

Files Patch % Lines
pymilo/transporters/function_transporter.py 90.91% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #63 +/- ## ========================================== + Coverage 85.91% 86.14% +0.23% ========================================== Files 27 28 +1 Lines 887 916 +29 Branches 149 151 +2 ========================================== + Hits 762 789 +27 - Misses 83 85 +2 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AHReccese commented 10 months ago

I applied all of your comments, I forgot to update CHANGELOG.md, I will update that and then you can finalize your review. @sadrasabouri