search

openscilab / pymilo

PyMilo: Python for ML I/O
MIT License
148 stars 5 forks source link

Feature/BisectingKMeans #66

Closed AHReccese closed 10 months ago

AHReccese commented 10 months ago

Reference Issues/PRs

17

What does this implement/fix? Explain your changes.

BisectingKMeans model support sklearn.cluster._bisect_k_means._BisectingTree Transporter fix a bug in tuple serialization in GeneralDataStructureTransporter Transporter enhance the test case for BayesianGaussianMixture Model fix shallow copy in pymilo_clustering_test func

Any other comments?

codecov[bot] commented 10 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (38f0a46) 86.18% compared to head (e7f5c4a) 86.90%. Report is 2 commits behind head on dev.

:exclamation: Current head e7f5c4a differs from pull request most recent head 4a4ad6d. Consider uploading reports for the commit 4a4ad6d to get more accurate results

Files Patch % Lines
pymilo/transporters/bisecting_tree_transporter.py 88.89% 2 Missing and 3 partials :warning:
pymilo/pymilo_param.py 66.67% 2 Missing :warning:
pymilo/chains/clustering_chain.py 85.72% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #66 +/- ## ========================================== + Coverage 86.18% 86.90% +0.72% ========================================== Files 28 29 +1 Lines 926 984 +58 Branches 154 165 +11 ========================================== + Hits 798 855 +57 + Misses 85 84 -1 - Partials 43 45 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AHReccese commented 10 months ago

Codacy failure is wrong since it hasn't understand conditional import so ignore it's failure. https://app.codacy.com/gh/openscilab/pymilo/pullRequest?prid=13343698 @sadrasabouri @sepandhaghighi