znicholls
commented
5 months ago Copying first set of discussions from email
Should the SCM executable be compiled and ready to run without dependencies? Hector has a dependency on a C++ library and we are trying to figure out the best way to handle that.
It's completely up to you (@openclimatedata worked out how to do the C distribution for pyhector so you could copy/use that https://github.com/openclimatedata/pyhector). We basically have 2 patterns in OpenSCM:
- specify as pypi dependency, everything just works: that's what FaIR and ciceroscmpy do (they're pure python)
- tell the user where to get the dependencies (pre-compiled or not), how to tell openscm-runner where to find them, how to set runtime environment etc. then run: that's what MAGICC does CICREO-SCM just put the binary in the openscm-runner package, but we don't want to do that anymore (see https://github.com/openscm/openscm-runner/issues/49)
On a somewhat related note, we’ve been struggling to get the Cicero running. Do you know if there is an extra dependency on our end that we would need to install?
CICEROSCMPY should just work. CICEROSCM requires the binary, but that's included in the package. The binary only works on linux systems. If you're on linux and it's still not working, probably best to make an issue and tag maritsandstad (she is generally very responsive).
Do modeling groups submit their own parameters for the 5/95th percentiles? Or does OpenSCM runner calculate them based on an ensemble of runs?
Neither really. OpenSCM-Runner just does the running (take a bunch of different model configs, run the model, return the results from each run). Then users can process them however they want. We tend to use process_over from scmdata but you could use whatever (https://scmdata.readthedocs.io/en/latest/notebooks/summary-statistics.html#process-over).
The examples in the lab notebooks look like scenario emissions start in 2015, what is being used for the historical portion of the run?
Good question. So, the ideal pattern is: user specifies emissions for the entire run, the model only runs over the period for which the emissions are provided. However, the real-world pattern (i.e. supporting IPCC emissions databases is): user specifies emissions for the future only, the model then has to add its own historical emissions onto these in order to create a full timeseries it can run with. At the moment, each model has its own module for grabbing historical emissions (e.g. for FaIR, it is happening in here: https://github.com/openscm/openscm-runner/blob/261bd177b86a708b0080eed245b6511ebb0051bb/src/openscm_runner/adapters/fair_adapter/_scmdf_to_emissions.py#L199). In theory, this means they could all be using different historical emissions. In practice, we did check this before AR6 but it's obviously something we want to improve at some point. I don't think the solution is particularly hard, so if you want to tackle that problem please feel free.
What units does OpenSCM runner expect the emission units in? Are they the same units as the RCMIP emission files?
Any: the idea is that the adapters deal with conversion from emissions' input units (whatever they may be) into the emissions required by the model. We generally use ScmRun's unit conversion for this (https://scmdata.readthedocs.io/en/latest/notebooks/scmrun.html#unit-conversion) but you are free to use whatever unit conversion set up you want before the data gets passed to Hector.
rgieseke
maritsandstad
kdorheim
noahprime
The motivation
Adds hector the set of models that can be used by OpenSCM-Runner
The proposed solution
Add
openscm_runner.adapaters.Hector. @kdorheim, @claudiatebaldi, and @noahprime will lead implementation.This issue will act as the overarching issue for tracking this implementation. We can split out further issues as needed.