search

openscm / openscm-twolayermodel

Implementations of two-layer models by Held et al. and Geoffroy et al.
https://openscm-two-layer-model.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Quote notebook install instructions in README #16

Closed ashiklom closed 3 years ago

ashiklom commented 3 years ago

bash doesn't seem to mind hard brackets, but zsh (note: the default shell on recent MacOS) doesn't like them in unquoted form and throws the following error:

zsh: no matches found: openscm-twolayermodel[notebooks]

This is easily resolved by quoting the full package name:

pip install "openscm-twolayermodel[notebooks]"

I would suggest tweaking this in the installation docs.

(Discovered as part of https://github.com/openjournals/joss-reviews/issues/2766).

znicholls commented 3 years ago

Awesome thanks! I've put a fix in #21 if you want to take a look

ashiklom commented 3 years ago

Looks great 👍