openscm / openscm-twolayermodel

Implementations of two-layer models by Held et al. and Geoffroy et al.
https://openscm-two-layer-model.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Add models #3

Closed znicholls closed 4 years ago

znicholls commented 4 years ago

Adds two-layer model and impulse response model. Also includes a notebook which goes through the details of why the two-layer and impulse response models are identical.

For reference:

znicholls commented 4 years ago

@rgieseke this is ready to have a first look at (there's a bug somewhere, something for later/tomorrow). Probably start with https://github.com/openscm/openscm-twolayermodel/blob/c84c8a4e2b4c6deab077a9f463486e1cf8589c23/notebooks/impulse-response-equivalence.ipynb then go from there during a reivew?

znicholls commented 4 years ago

Minor consistency thing, there are a few variables like lambda_0 or b_pt_1 with underscores before the number, most others without, maybe unify?

Done

rgieseke commented 4 years ago

What is the 't' prefix for variables, just for testing?

rgieseke commented 4 years ago

All green! Should we merge this now?

znicholls commented 4 years ago

Yep t for test.

I will wrangle pylint for 20 minutes, then we can merge.