JOSS paper - Githubissues

znicholls commented 4 years ago

Add JOSS paper

znicholls commented 4 years ago

@rgieseke can you take a look please? I think JOSS are now accepting papers again

rgieseke commented 3 years ago

Looks good to me! I think i haven't contributed significantly during the model implementation, so i removed myself from the authors list.

Some comments/suggestions on the paper text below:

maybe add a sentence describing the model assumptions of the two layers? It is described how it is extended but not really the initial fast/slow components
add reference to RCMIP Phase 1 paper, where this implementation is used, this feeds also in the required "Statement of Need", as it was sort of a benchmark model for RCMIP
has FaIR already implemented this (as alluded in last paragraph) https://github.com/OMS-NetZero/FAIR/blob/master/fair/temperature/geoffroy.py The point of FaIR not being modularised yet is probably a bit out of scope for the JOSS paper. The two sentences on FaIR could probably be condensed into one.
last sentence, maybe just "used in research or education", "interested parties" is probably would use it for research or (self-)education
make RCP, CMIP5, AOGCM uppercase in BibTex bibliography
make tag "simple climate model" instead of "simple models"
add tag "reduced complexity climate model"
add tag "energy balance"

znicholls commented 3 years ago

Awesome thanks! Time to submit :)

openscm / openscm-twolayermodel