search

openscm / pymagicc

Python wrapper for the simple climate model MAGICC
https://pymagicc.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
39 stars 27 forks source link

pymagicc.io refactor #303

Closed lewisjared closed 4 years ago

lewisjared commented 4 years ago

Pull request

Please confirm that this pull request has done the following:

Separated pymagicc.io from a module into a package. Each file type is now in its own module to make it easier to edit in future.

A future cleanup would be splitting the tests, but I tried to not touch them in the PR

lewisjared commented 4 years ago

@znicholls Any idea what's gone wrong with the window runners?

znicholls commented 4 years ago

A future cleanup would be splitting the tests, but I tried to not touch them in the PR

Nice yep let's leave for the next one

znicholls commented 4 years ago

Any idea what's gone wrong with the window runners?

Nope, they won't even clone the repo...

codecov[bot] commented 4 years ago

Codecov Report

Merging #303 into master will increase coverage by 0.23%. The diff coverage is 94.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   93.38%   93.61%   +0.23%     
==========================================
  Files           7       18      +11     
  Lines        2419     2429      +10     
  Branches      495      475      -20     
==========================================
+ Hits         2259     2274      +15     
+ Misses        102       99       -3     
+ Partials       58       56       -2
Impacted Files Coverage Δ
pymagicc/io/compact.py 87.17% <87.17%> (ø)
pymagicc/io/__init__.py 89.04% <89.04%> (ø)
pymagicc/io/binout.py 89.65% <89.65%> (ø)
pymagicc/io/prn.py 90.41% <90.41%> (ø)
pymagicc/io/out.py 90.47% <90.47%> (ø)
pymagicc/io/base.py 94.80% <94.80%> (ø)
pymagicc/io/mag.py 95.77% <95.77%> (ø)
pymagicc/io/rcpdat.py 96.14% <96.14%> (ø)
pymagicc/io/scen.py 97.19% <97.19%> (ø)
pymagicc/core.py 88.88% <100.00%> (+0.04%) :arrow_up:
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b422265...eb4970a. Read the comment docs.

lewisjared commented 4 years ago

@znicholls After some battling, I got it green

znicholls commented 4 years ago

One notebook ignore missing

znicholls commented 4 years ago

Tidy