openscm / pymagicc

Python wrapper for the simple climate model MAGICC
https://pymagicc.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
39 stars 27 forks source link

Make level check stricter #332

Closed znicholls closed 3 years ago

znicholls commented 3 years ago

Pull request

Please confirm that this pull request has done the following:

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)
znicholls commented 3 years ago

Pretty minor but hopefully makes sense @lewisjared

codecov[bot] commented 3 years ago

Codecov Report

Merging #332 (13c9143) into master (c9bdd61) will increase coverage by 0.04%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   93.20%   93.25%   +0.04%     
==========================================
  Files          20       20              
  Lines        2591     2594       +3     
  Branches      513      515       +2     
==========================================
+ Hits         2415     2419       +4     
  Misses        111      111              
+ Partials       65       64       -1     
Impacted Files Coverage Δ
pymagicc/core.py 88.08% <0.00%> (ø)
pymagicc/io/compact.py 87.50% <100.00%> (+0.32%) :arrow_up:
pymagicc/io/scen.py 97.66% <100.00%> (+0.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 75c91f2...13c9143. Read the comment docs.

znicholls commented 3 years ago

Ignoring codecov