openscm / pymagicc

Python wrapper for the simple climate model MAGICC
https://pymagicc.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
39 stars 27 forks source link

Update dependencies #344

Closed phackstock closed 11 months ago

phackstock commented 11 months ago

Pull request

This PR updates the following dependencies to the currently latest versions:

the biggest change is pandas 2 which broke a number of tests. I have done my best to implement fixes related to deprecated pandas functionality. There's still currently a couple of tests failing on my machine. They are:

@znicholls or @lewisjared I checked Allow edits by maintainers in case you have time to take a look. Could be easier for you to fix the remaining failing tests.

znicholls commented 11 months ago

Awesome. I've got to do some other work but I can then take a look at getting the CI running again and see where we end up...

phackstock commented 11 months ago

Looks like we'll have to wave goodbye to python3.7 and 3.8 with this PR as scmdata 0.16.1 requires >=3.9.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b6e9c1a) 93.25% compared to head (20c5eb2) 93.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #344 +/- ## ========================================== + Coverage 93.25% 93.30% +0.05% ========================================== Files 20 20 Lines 2594 2614 +20 Branches 515 544 +29 ========================================== + Hits 2419 2439 +20 Misses 111 111 Partials 64 64 ``` | [Files](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm) | Coverage Δ | | |---|---|---| | [pymagicc/core.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvY29yZS5weQ==) | `88.08% <100.00%> (ø)` | | | [pymagicc/io/\_\_init\_\_.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvaW8vX19pbml0X18ucHk=) | `88.72% <ø> (+0.08%)` | :arrow_up: | | [pymagicc/io/base.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvaW8vYmFzZS5weQ==) | `94.87% <100.00%> (ø)` | | | [pymagicc/io/compact.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvaW8vY29tcGFjdC5weQ==) | `87.50% <ø> (ø)` | | | [pymagicc/io/rcpdat.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvaW8vcmNwZGF0LnB5) | `96.14% <100.00%> (ø)` | | | [pymagicc/io/scen.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvaW8vc2Nlbi5weQ==) | `97.66% <ø> (ø)` | | | [pymagicc/io/scen7.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvaW8vc2NlbjcucHk=) | `100.00% <ø> (ø)` | | | [pymagicc/magicc\_time.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvbWFnaWNjX3RpbWUucHk=) | `100.00% <100.00%> (ø)` | | | [pymagicc/utils.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvdXRpbHMucHk=) | `90.90% <ø> (ø)` | | | [pymagicc/io/binout.py](https://app.codecov.io/gh/openscm/pymagicc/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm#diff-cHltYWdpY2MvaW8vYmlub3V0LnB5) | `89.91% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/openscm/pymagicc/pull/344/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openscm)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

znicholls commented 11 months ago

Alright @phackstock here goes nothing

znicholls commented 11 months ago

Thanks for your help getting this started, still lots to do but that's a job for another day