Closed phackstock closed 11 months ago
Awesome. I've got to do some other work but I can then take a look at getting the CI running again and see where we end up...
Looks like we'll have to wave goodbye to python3.7 and 3.8 with this PR as scmdata 0.16.1 requires >=3.9.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
b6e9c1a
) 93.25% compared to head (20c5eb2
) 93.30%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Alright @phackstock here goes nothing
Thanks for your help getting this started, still lots to do but that's a job for another day
Pull request
This PR updates the following dependencies to the currently latest versions:
the biggest change is pandas 2 which broke a number of tests. I have done my best to implement fixes related to deprecated pandas functionality. There's still currently a couple of tests failing on my machine. They are:
test_load_rewritten_scen7
failing because there's two warnings instead of one(fixed per 2af4eb1)test_writing_identical_rcpdat
all the tests withadd_extra_data = True
are failingtest_default_config
andtest_readme
seem to be failing because I don't have wine installed. I tried to install it but somehow my antivirus marks it as a virus and does not let me install it.[ ]
Tests added[ ]
Documentation added (where applicable)[ ]
Example added (either to an existing notebook or as a new notebook, where applicable)[ ] Description in
CHANGELOG.rst
added@znicholls or @lewisjared I checked Allow edits by maintainers in case you have time to take a look. Could be easier for you to fix the remaining failing tests.