openscm / scmdata

Handling of Simple Climate Model data
https://scmdata.readthedocs.io
BSD 3-Clause "New" or "Revised" License
8 stars 5 forks source link

Fix deprecation warnings #298

Closed znicholls closed 10 months ago

znicholls commented 10 months ago

Pull request

Couple of quick fixes to stop deprecation warnings spewing out when using scmdata.

Please confirm that this pull request has done the following:

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3b61470) 95.15% compared to head (8643ec3) 95.16%. Report is 4 commits behind head on master.

:exclamation: Current head 8643ec3 differs from pull request most recent head ea5bcb5. Consider uploading reports for the commit ea5bcb5 to get more accurate results

Files Patch % Lines
src/scmdata/run.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #298 +/- ## ======================================= Coverage 95.15% 95.16% ======================================= Files 24 24 Lines 2190 2109 -81 Branches 404 379 -25 ======================================= - Hits 2084 2007 -77 + Misses 86 85 -1 + Partials 20 17 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lewisjared commented 10 months ago

Nice. Do we need to bump the minimum version of seaborn to what ever major release added the errorbar parameter?

znicholls commented 10 months ago

Do we need to bump the minimum version of seaborn to what ever major release added the errorbar parameter?

True, thanks