search

openscopeproject / TrguiNG

Remote GUI for Transmission torrent daemon
GNU Affero General Public License v3.0
372 stars 47 forks source link

Colorful peers table #216

Closed melyux closed 2 months ago

melyux commented 3 months ago

Implements a more visually colorful peers table instead of just bare text. Only applies if the corresponding setting is turned on. I use this for quicker discernment in a big list of peers as opposed to the plain text. Thought others might find it appealing too.

image

Goes from this:

image

to:

Screenshot 2024-08-06 at 10 05 26 PM

Uses blue as the badge color for the most "default" option (from: tracker, connection: outgoing, protocol: TCP). Uses green as the more "good" option when there's only 2 possible options (connection: incoming, protocol: μTP). Uses yellow and red for the more "good" options when there are 3 possible options, like for "from": blue for the default of tracker, yellow for PEX, and red for DHT.

Also, uses a lock icon for encryption instead of just saying "yes" and "no". This is not toggleable, since the existing structure would need some refactoring, but let me know if that should be toggled too.

Pentaphon commented 3 months ago

Not sure I like this. I prefer the text, especially with the way uTP is written. I'd rather see the lock icon get a revamp to be more colorful, modern and distinct. It is an option though, but I guess it is up to the dev.

I think improving the icons is a better way to improve the overall look of the client. Especially on the menu when you right click a torrent.

qu1ck commented 3 months ago

I don't see much value here but don't oppose to it either, since it's optional. But several things need to be addressed:

  1. Set the setting default to false
  2. No emojis. In fact lock icon is not a good fit. If you want to have more visual distinction you can change the text to yes/<empty> instead of yes/no.
  3. Don't use the switch component, I plan to phase it out, plain checkbox is better.
  4. Don't change the column label.
melyux commented 2 months ago

I think I'll close this one since I do like those parts of it :) I'll keep it as a personal patch

@Pentaphon Apparently the uppercase of μTP is MTP in Greek, and that didn't look as clear as UTP. Quite unfortunate

Pentaphon commented 2 months ago

Apparently the uppercase of μTP is MTP in Greek, and that didn't look as clear as UTP. Quite unfortunate

Yes, it definitely would be a step down as MTP or UTP. Your other patches have been great, though!