openscriptures / morphhb

Open Scriptures Hebrew Bible
https://hb.openscriptures.org
Other
178 stars 63 forks source link

Add linking capability (to Read app) #103

Closed marcstober closed 2 months ago

marcstober commented 2 months ago

This adds linking capability to the Read app, in the same way it already works in the Verse app.

I attempted to match the Verse app as much as possible. This adds some duplicated code between the Read and Verse apps, but that seemed to already be the approach used to maintain these two apps. There are some other things I might have done differently if making this from scratch (like updating window.location automatically when a user changes the drop-down value, or using let/const in new development) but my goal here was to be consistent with the existing Verse app with minimal other changes.

The one change a user would notice (besides the new functionality) is that the read app no longer opens by default to Haggai, but to Genesis. There was a comment (I removed) that opening by default to Haggai was for testing, and I thought it made sense to match the functionality of Verse app (which defaults to Genesis).