openscriptures / morphhb

Open Scriptures Hebrew Bible
https://hb.openscriptures.org
Other
178 stars 63 forks source link

Additional linking capability from Read to Lexicon. #104

Open marcstober opened 2 months ago

marcstober commented 2 months ago

Thank you for accepting my recent pull request #103 to add linking to the Read app.

I've taken this a step further and added linking capability from the Read app to the Lexicon. You can see this in action at https://marcstober.github.io/morphhb/read/index.html. Hover on a word, and now you can click on the lemma (e.g., Strong's number) in the popup, and be taken to the related entry in the Lexicon.

I haven't submitted a pull request for a few reasons, the biggest one of which is that actually deploying it would require some coordinated changes between the Read and Lexicon apps (currently there's a hard-coded URL to my fork). It's also a little more involved of a change that is really just a proof-of-concept for some other things I am working on; I'm not sure if what I have is exactly what should go on openscriptures.org. In any case, the code is in my Github account (with a CC-BY license), so I wanted to let you know in case you wanted it.