search

openscriptures / morphhb

Open Scriptures Hebrew Bible
https://hb.openscriptures.org
Other
178 stars 64 forks source link

Fixed the order of XML elements in each work element #49

Closed DavidHaslam closed 6 years ago

DavidHaslam commented 6 years ago

See https://github.com/openscriptures/morphhb/issues/48

Also fixed the XML entity in <publisher>Hunt &amp; Eaton</publisher>

The latter may have been introduced by someone's scripting error. i.e. Converting every & to &amp; without guarding existing XML entities.

jag3773 commented 6 years ago

@DavidHaslam It may be that @AndyHubert wants to resolve these issues in his export script, which would mean our next release will have these fixes incorporated. Is that true @AndyHubert ?

We are planning another release soon, in the next 2 weeks.

DavidHaslam commented 6 years ago

@jag3773 @AndyHubert

The systematic correction I did was intended to demonstrate that these issues can be successfully resolved.

If there's an upstream method to achieve the same results, that's fine by me.

Please let me know, though, if that's what you will have done, then I can delete the PR.

NB. There are now file conflicts with my PR that I don't recall seeing when I first issued the request.

AndyHubert commented 6 years ago

These changes have been made in the export script and are reflected in the release-3 pull request.

DavidHaslam commented 6 years ago

Thanks @AndyHubert

I will delete my branch.