openscriptures / morphhb

Open Scriptures Hebrew Bible
https://hb.openscriptures.org
Other
178 stars 63 forks source link

Changes requested by Randall Tan and Joel Ruark from Clear Trees work. #91

Open jonathanrobie opened 2 years ago

jonathanrobie commented 1 year ago

Adding Randall, David, Joel, and Reinier.

I think you each contributed to the merge request. Could you all please take a look at this respond to Johan's comment?

https://github.com/openscriptures/morphhb/pull/91#pullrequestreview-1377446976

Looks like this may be merged in soon.

Blessings!

Jonathan

On Mon, Apr 10, 2023 at 8:01 AM J. de Joode @.***> wrote:

@.**** commented on this pull request.

In wlc/1Kgs.xml https://github.com/openscriptures/morphhb/pull/91#discussion_r1161665886 :

@@ -6542,7 +6542,7 @@

מֵא֣וֹת כֶּ֔סֶף וְ/ס֖וּס
  • בַּ/חֲמִשִּׁ֣ים
  • בַּ/חֲמִשִּׁ֣ים

Could someone help me understand the logic to remove the definite article here? Is that because of the parallel with בְּ/שֵׁ֣שׁ? Or because the number is implicitly definite? Or is the patah wrong here? Westminster Morphology here has a definite article, which is in line with the vowel.

— Reply to this email directly, view it on GitHub https://github.com/openscriptures/morphhb/pull/91#pullrequestreview-1377446976, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANPTPMEK3ULXWLIMZBCTWDXAPZAJANCNFSM5QOAUSVA . You are receiving this because you authored the thread.Message ID: @.***>

jdejoode commented 10 months ago

@jonathanrobie What's the best way forward to resolve the outstanding questions?