search

openseadragon / browser-extension

OpenSeadragonizer: zooming browser extension
BSD 3-Clause "New" or "Revised" License
17 stars 2 forks source link

Imagetilesource #13

Closed avandecreme closed 8 years ago

avandecreme commented 8 years ago

Still need to handle error from OSD with the tile-load-failed event. Open for discussion in the mean time.

iangilman commented 8 years ago

Seems good to me...glad to have the upgrade!

avandecreme commented 8 years ago

The tile-load-failed event can't actually be fired with the ImageTileSource. I can't actually think of any failure we could have in OSD since OSD is started only when the image has been entirely loaded. So I just don't listen to any failure event.

iangilman commented 8 years ago

Makes sense.

The new code is looking good. One question: why the encoded URL param?

avandecreme commented 8 years ago

One question: why the encoded URL param?

Because if the image url has parameters, we need to encode it to properly distinguish it from the extension own's parameters. However, I wanted to leave the capability to use non encoded URL for easier sharing of an openseadragonized image: you just need to post a link to openseadragonize/index.html?url=theURL 99% of the time.

iangilman commented 8 years ago

Makes sense. I wonder if it might be worth doing some auto detection...if there is a % in the URL, assume it's decoded, and if there isn't, assume it's not. We could still have the encoded param as an override if need be.