openseadragon / openseadragon

An open-source, web-based viewer for zoomable images, implemented in pure JavaScript.
http://openseadragon.github.io/
BSD 3-Clause "New" or "Revised" License
3.04k stars 596 forks source link

Visualisation error with zoomifytilesource.js #1169

Open arrigo55 opened 7 years ago

arrigo55 commented 7 years ago

I tested the zoomifytilesource with two different Zoomify images. The first one https://drive.google.com/open?id=0B1mkW7rsGhsPWEN6M3gxZi1ScFk is small (width: 4096 height: 4096) and the visualisation with Openseadragon is perfect. The second one https://drive.google.com/open?id=0B1mkW7rsGhsPR2IzR0x3OHM2QmM is a large image (width: 81920 height: 103349) and the visualisation is poor. The images can be seen at http://www.syliconstuga.cloud/osd-zmf/ops/small = small one visualised with with Openseadragon http://www.syliconstuga.cloud/osd-zmf/zmf/small = small one visualised with Zoomify

http://www.syliconstuga.cloud/osd-zmf/ops/large = large one visualised with with Openseadragon http://www.syliconstuga.cloud/osd-zmf/zmf/large = large one visualised with with Zoomify

The ImageProperties.xml files are included in the two downloads. Any suggestion? Thanks

iangilman commented 7 years ago

@foobarable would you mind taking a look at this?

foobarable commented 7 years ago

@iangilman Yes, I can do this, but it will need some time.

foobarable commented 7 years ago

@arrigo55 How did you create the zoomify images?

foobarable commented 7 years ago

@arrigo55 You did not specify the height of the image correctly: Compare the height in your javascript with the height of the ImageProperties.xml.

foobarable commented 7 years ago

@iangilman Probably we still should add the functionality to read the dimensions from the ImageProperties.xml file.

arrigo55 commented 7 years ago

Yes, there was a mistake in the Height parameter of my index.html file. Now it is correct, but the result is still quite different from the expected one.

iangilman commented 7 years ago

@foobarable Yes, being able to get the dimensions from the ImageProperties.xml would be good! That's how it works with DZI, for instance. Keep in mind that the image dimensions are different than the viewport coordinates for the image. That said, we always force the viewport coordinates to have the same aspect ratio as the image, even if the scale is different.

foobarable commented 7 years ago

@arrigo55 In your example it looks good now. What did you change?

Edit: No, some tiles are still not correctly loaded :/

foobarable commented 7 years ago

It seems there is some error after zoomlevel 6 so the tiles are loaded from the wrong tilegroup

iangilman commented 7 years ago

Interesting... glad you're making progress on tracking down the issue! :)

arrigo55 commented 7 years ago

I simply put the correct height value in the javascript. The result looks good only at low magnification. As you said in one of the following posts it seems there is something wrong at high magnification. Thank you for your precious work.

2017-04-24 8:28 GMT+02:00 foobarable notifications@github.com:

@arrigo55 https://github.com/arrigo55 In your example it looks good now. What did you change?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openseadragon/openseadragon/issues/1169#issuecomment-296537317, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ0YNs0vF64KBYwPp-phDnmTLmfB0QiNks5rzEEVgaJpZM4NB6FF .

foobarable commented 7 years ago

I currently don't have the time to analize the issue here, so the solution may be delayed. Sorry

iangilman commented 7 years ago

Okay, thanks for the update. Hopefully you can get to it eventually!

If anyone else wants to take a look, please do :)