search

openseadragon / openseadragon

An open-source, web-based viewer for zoomable images, implemented in pure JavaScript.
http://openseadragon.github.io/
BSD 3-Clause "New" or "Revised" License
3.04k stars 597 forks source link

Tile seams appear on M2 Macs, Chrome, and WebGL #2617

Open cincospenguinos opened 1 week ago

cincospenguinos commented 1 week ago

We get tile seams on the new WebGL drawer, but only on M2 macs without an overlap defined in Chrome. Our underlying files have a set of tiles that are meant to be drawn right next to each other without padding or overlap. We only see tile seams on M2, M3, and M4 Macs in both Chrome and Edge.

I put together a demo here: #2616

iangilman commented 1 week ago

@cincospenguinos Thank you for the report and the demo!

@pearcetm Any thoughts? Do you have access to an M2 or greater Mac to test on?

I'm on an M1 Mac and I'm not seeing the seams in the demo.

pearcetm commented 1 week ago

I'm on an M1 Mac and I'm not seeing the seams in the demo.

I'm also on M1 and don't see seams. I'll see if I can find an M2 to test on.

cincospenguinos commented 1 week ago

I'm on an M1 Mac and I'm not seeing the seams in the demo.

I'm also on M1 and don't see seams. I'll see if I can find an M2 to test on.

I was able to duplicate this issue by spinning up an EC2 instance on AWS. I used these instructions to do it. My team and I won't be able to help with development work, but if y'all pull together a patch and would like us to try it on our end, feel free to reach out.

pearcetm commented 1 week ago

@cincospenguinos Any chance you can share access credentials to the EC2 instance you mentioned? I can send you my email address if you'd like. I don't particularly want to go through all the setup for doing that myself since I don't really have an active AWS account at the moment, and I haven't found an M2 or higher system to work with yet.

Either way, does setting overlap on your tile source actually fix the issue, or does it still show seams even with positive overlap?

cincospenguinos commented 1 week ago

@cincospenguinos Any chance you can share access credentials to the EC2 instance you mentioned? I can send you my email address if you'd like. I don't particularly want to go through all the setup for doing that myself since I don't really have an active AWS account at the moment, and I haven't found an M2 or higher system to work with yet.

Either way, does setting overlap on your tile source actually fix the issue, or does it still show seams even with positive overlap?

My company is working with DICOM files which contains tiles without any overlap within the image. We'll try increasing the overlap and see what that does, but in previous tries we'd get incorrect presentation of the various tiles.

RE: EC2 instance, that's a question I'll have to ask my up and ups. I'll keep you posted on that one.

pearcetm commented 1 week ago

RE: EC2 instance, that's a question I'll have to ask my up and ups. I'll keep you posted on that one.

This may not be needed.

My company is working with DICOM files which contains tiles without any overlap within the image. We'll try increasing the overlap and see what that does, but in previous tries we'd get incorrect presentation of the various tiles.

As mentioned in https://github.com/openseadragon/openseadragon/pull/2616#issuecomment-2480491744 I think you just need to set tileOverlap: 0 (since your tiles really have no overlap).

Playing around with my system, I discovered that on my M1 mac, I can replicate your issue if I set the overlap to be 0.0001 greater than it should be (i.e. if overlap is supposed to be 0, setting it to 0.0001, if true overlap is 1, setting to 1.0001). Increased zeros make it go away, but I'm betting the M2+ macs just have more precision so the issue shows up with the value you are using.