search

openseadragon / site-build

Build script and documents for the OpenSeadragon site
http://openseadragon.github.io/
6 stars 67 forks source link

Documentation on advanced data model in OSD. #258

Closed Aiosa closed 1 year ago

Aiosa commented 2 years ago

This part obviously does not work unless https://github.com/openseadragon/openseadragon/pull/2148 gets merged.

Aiosa commented 2 years ago

In case of testing while waiting for the referenced PR, replace OpenSeadragon build in this repo with a build generated either from the PR or my master fork (https://github.com/Aiosa/openseadragon). Also, for the first example, local images are needed.

Aiosa commented 2 years ago

Could you please comment on the CORS and the inline VS override? Thank you.

iangilman commented 2 years ago

Sorry for the delayed response, by the way… been out of town!

Aiosa commented 2 years ago

I am also sorry for the typos should've opened it in a proper editor earlier. Apart from the overriding, it is finished. I think this way the example is more 'educational', however, I can see that this might also lead people to copy-paste and potentially introduce unwanted behavior. So If you want me to change it to inline specification I will try, although it will take some time to go through the DZI to extract necessary parts... I could as well as hardcode the attributes but then it is no better in the code practice than overriding the default DZI. A solution might be to extend the class instead and register it as a new protocol, however, then it would not be obvious which protocol will be used, based on which one is encountered first....

iangilman commented 1 year ago

Okay, we're releasing the next OSD, so I'm merging this!