opensearch-project / .github

Provides templates and resources for other OpenSearch project repositories.
Apache License 2.0
28 stars 71 forks source link

[BUG] Pull requests to do not have quality gates. #149

Closed peternied closed 1 year ago

peternied commented 1 year ago

Problem

This .github repository represents OpenSearch-Project's policies, ideals, and intentions. This repository has no quality gates other than 2 approvals and a DCO check - making the way pull requests are accepted subjective based on which maintainers/contributors first responded.

Expectation

There should be mechanisms to ensure a minimum quality of the changes that are accepted into this repository.

peternied commented 1 year ago

[Proposal] Add a 'bake time' before pull requests can be merged

As most changes to this repo are subjective, providing more time for additional comments and visibility would get more perspectives on changes and improve the quality of merged changes.

wbeckler commented 1 year ago

What if we increase the number of required approvals? I'm thinking that the day may come when we'll want to push something through quickly in an emergency, although I can't imagine what situation would cause that in this repo.

dblock commented 1 year ago

@wbeckler I believe admins can always override gates

Screenshot 2023-03-28 at 11 20 50 AM

dblock commented 1 year ago

@peternied shall we close this now that we do have bake time? or do you want to keep it open for more actions?

peternied commented 1 year ago

Yea - this looks good for now.