search

opensearch-project / .github

Provides templates and resources for other OpenSearch project repositories.
Apache License 2.0
28 stars 71 forks source link

Add start-opensearch action #190

Closed derek-ho closed 4 months ago

derek-ho commented 4 months ago

Description

This PR adds a start-opensearch action to this shared repo. There are many instances of plugins in their own CI spinning up their own opensearches to test against, and there is a lot of duplicate code out there.

Examples: https://github.com/opensearch-project/security/blob/main/.github/actions/start-opensearch-with-one-plugin/action.yml https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/actions/run-cypress-tests/action.yml#L38 https://github.com/opensearch-project/dashboards-observability/blob/main/.github/workflows/ftr-e2e-dashboards-observability-test.yml#L49

I would like to get some maintainers views on the path forward to getting this in and used in repos across the project.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dblock commented 4 months ago

Another option is https://github.com/opensearch-project/opensearch-plugins. But I agree that a standalone action published to the GitHub Actions marketplace is probably best.

I propose we close this without merging?

derek-ho commented 4 months ago

Sure, closing. For reference I created the proposed action(s) under my own github