opensearch-project / OpenSearch-Dashboards

📊 Open source visualization dashboards for OpenSearch.
https://opensearch.org/docs/latest/dashboards/index/
Apache License 2.0
1.69k stars 893 forks source link

[BUG] Min RPM not able to install on AL2 due to arch file name change #1401

Open peterzhuamazon opened 2 years ago

peterzhuamazon commented 2 years ago

This is probably some issues caused by the renaming. When introducing deb/rpm arm64 in dashboards, we also ask to rename x86_64 to x64 on the file, and aarch64 to arm64 on the file.

This caused the internal arch somehow being changed during the build.

The filename can be changed to x64/arm64, but internally the rpms should be built as x86_64 and aarch64.

This issue probably is showing in deb as well.

% sudo yum install opensearch-dashboards-min-1.3.0-x64.rpm
Loaded plugins: priorities, remove-with-leaves
Examining opensearch-dashboards-min-1.3.0-x64.rpm: opensearch-dashboards-1.3.0-1.x64
Cannot add package opensearch-dashboards-min-1.3.0-x64.rpm to transaction. Not a compatible architecture: x64
Error: Nothing to do
% rpm -qip opensearch-dashboards-min-1.3.0-x64.rpm
Name        : opensearch-dashboards
Version     : 1.3.0
Release     : 1
Architecture: x64
Install Date: (not installed)
Group       : default
Size        : 292620171
License     : ASL 2.0
Signature   : (none)
Source RPM  : opensearch-dashboards-1.3.0-1.src.rpm
Build Date  : Mon 28 Mar 2022 09:43:49 PM UTC
Build Host  : dev-dsk-zhujiaxi-2a-5c9b3e5e.us-west-2.amazon.com
Relocations : /
Packager    : OpenSearch Dashboards Team <opensearch@amazon.com>
Vendor      : OpenSearch
URL         : https://opensearch.org
Summary     : Explore and visualize your OpenSearch data
Description :

Since bundle rpm is not directly using min rpm, but rather extract it and repackage, this does not seems like a blocker for now, but would be an issue for any users who generate min themselves and found the package not usable.

Thanks.

peterzhuamazon commented 2 years ago

During the build deb should use amd64/arm64, after build rename to x64/arm64 During the build rpm should use x86_64/aarch64, after build rename to x64/arm64