search

opensearch-project / OpenSearch-Dashboards

📊 Open source visualization dashboards for OpenSearch.
https://opensearch.org/docs/latest/dashboards/index/
Apache License 2.0
1.62k stars 834 forks source link

[Branding] Remove or allow to disable url validation #1740

Open ARud12 opened 2 years ago

ARud12 commented 2 years ago

How can I remove the URL validation process for the branding icons as well as for the pdf reporting plugin without modifying the source code of OpenSearch Dashboards?

kavilla commented 2 years ago

[Triage]: @ARud12, thanks for opening.

There is currently not a way to do this but we will take this as a feature request.

ARud12 commented 2 years ago

Thank you. Will this feature request include both URL validation for the branding icons as well as the pdf reporting plugin?

joshuarrrr commented 2 years ago

In this repo, we only have control over the branding assets, so it will cover those. I think you can continue the discussion in https://github.com/opensearch-project/dashboards-reports/issues/374#issuecomment-1154863775 for the reporting plugin pdf validation.

joshuarrrr commented 2 years ago

I think the best approach to address this use case is an optional config value that allows admins to disable the branding validation checks.

ARud12 commented 2 years ago

Yes that will be ideal. What is the estimated waiting time for this feature to be incorporated?

joshuarrrr commented 2 years ago

We don't currently have this on scheduled to our roadmap, but it will be part of a number of improvements to the branding experience (everything labeled https://github.com/opensearch-project/OpenSearch-Dashboards/labels/branding).