opensearch-project / OpenSearch-Dashboards

📊 Open source visualization dashboards for OpenSearch.
https://opensearch.org/docs/latest/dashboards/index/
Apache License 2.0
1.69k stars 893 forks source link

Remove KUI usage in `visualizations` #3386

Open joshuarrrr opened 1 year ago

joshuarrrr commented 1 year ago

Based on a quick initial search, this plugin only defines some kui classes in the DisabledLabVisualization component:

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/5b8a378f38bdcd1223747fddfa9b791ec3071931/src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx#L38

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/5b8a378f38bdcd1223747fddfa9b791ec3071931/src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx#L41

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/5b8a378f38bdcd1223747fddfa9b791ec3071931/src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx#L48

To resolve

sayuree commented 1 year ago

@joshuarrrr Hello, I want to work on this issue, can you please assign it to me?

sayuree commented 1 year ago

@joshuarrrr You have highlighted kuiVerticalRhythm class to be renamed to have component scoped class name, however, in the SCSS file we also have classes starting from kui such as:

joshuarrrr commented 1 year ago

We're not actually interested in renaming the KUI classes themselves, because we want to get rid of KUI altogether. What this issue aims to do is to remove any KUI classes added to elements in the visualize plugin, without changing the actual CSS applied to those elements. So while there are many other KUI classes defined, we only care about the ones that are still in use and providing styles of some sort.

BSFishy commented 1 year ago

@sayuree are you still working on this issue? It seems to be stale. If not, we'd like to unassign you.

caileyjen commented 1 year ago

Hello! I'm interested in continuing work on this issue, could you please assign it to me @joshuarrrr @BSFishy ?

joshuarrrr commented 1 year ago

@caileyjen This issue has some updated requirements we discovered in the first PR - I'll try and update the issue description, but make sure to read https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3855#issuecomment-1599751417 for the mitigation required.