[Dashboard De-Angular] Dashboard listing to use viewItem

opensearch-project / OpenSearch-Dashboards

📊 Open source visualization dashboards for OpenSearch.

https://opensearch.org/docs/latest/dashboards/index/

Apache License 2.0

1.69k stars 893 forks source link

[Dashboard De-Angular] Dashboard listing to use viewItem #4605

Open abbyhu2000 opened 1 year ago

abbyhu2000 commented 1 year ago

Currently dashboard listing page uses href to view dashboards instead of utilizing onclick. Before the dashboard observability integration, the code utilized a getViewUrl prop to pass in a function; but this is dropped in favor of using viewUrl which is mapped from the viewUrlPathFn from the dashboard list provider.

https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4502/files#r1258627999

shawnkchan commented 1 year ago

Hi, I would like to work on this issue. May I know where to start?

joshuarrrr commented 11 months ago

@abbyhu2000 Can you explain a little more about why this is desirable? There are a11y benefits to using links with hrefs rather than a js action, because you get all the built-in browser functionality (such as open in a new tab). Elsewhere we've updated the visualization listing to have that behavior: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2395