opensearch-project / OpenSearch-Dashboards

📊 Open source visualization dashboards for OpenSearch.
https://opensearch.org/docs/latest/dashboards/index/
Apache License 2.0
1.58k stars 796 forks source link

[Manual backport 2.14] Backport/backport 6760 to 2.14 #6767

Closed abbyhu2000 closed 3 weeks ago

abbyhu2000 commented 3 weeks ago

Manual backport of #6613 to 2.14.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 26.66667% with 308 lines in your changes are missing coverage. Please review.

Project coverage is 67.53%. Comparing base (1d8d363) to head (0ee916c).

Files Patch % Lines
src/plugins/data/common/data_frames/utils.ts 9.33% 136 Missing :warning:
src/plugins/data/public/ui/settings/settings.ts 0.00% 24 Missing :warning:
...public/ui/query_string_input/query_bar_top_row.tsx 16.00% 17 Missing and 4 partials :warning:
.../data/common/search/search_source/search_source.ts 15.78% 14 Missing and 2 partials :warning:
...public/ui/query_string_input/language_switcher.tsx 56.66% 8 Missing and 5 partials :warning:
src/plugins/data/public/search/search_service.ts 20.00% 12 Missing :warning:
src/plugins/data/server/search/search_service.ts 7.69% 12 Missing :warning:
src/plugins/data/public/ui/ui_service.ts 0.00% 11 Missing :warning:
...on/index_patterns/index_patterns/index_patterns.ts 38.46% 6 Missing and 2 partials :warning:
...on/search/search_source/fetch/get_search_params.ts 33.33% 6 Missing and 2 partials :warning:
... and 16 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.14 #6767 +/- ## ========================================== - Coverage 67.80% 67.53% -0.28% ========================================== Files 3413 3424 +11 Lines 66899 67279 +380 Branches 10874 10973 +99 ========================================== + Hits 45363 45439 +76 - Misses 18894 19172 +278 - Partials 2642 2668 +26 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6767/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [Linux_1](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `33.05% <12.73%> (-0.12%)` | :arrow_down: | | [Linux_2](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `55.24% <8.36%> (-0.45%)` | :arrow_down: | | [Linux_3](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `44.97% <26.87%> (-0.29%)` | :arrow_down: | | [Linux_4](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `34.85% <11.74%> (-0.16%)` | :arrow_down: | | [Windows_1](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `33.07% <12.73%> (-0.12%)` | :arrow_down: | | [Windows_2](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `55.21% <8.36%> (-0.45%)` | :arrow_down: | | [Windows_3](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `44.99% <26.87%> (-0.27%)` | :arrow_down: | | [Windows_4](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `34.85% <11.74%> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kavilla commented 3 weeks ago

we've decided to hold this off to 2.15