kavilla
commented
1 month ago Hello @ArielGMachado, thanks for opening. And yeah @joshuarrrr is right, I'm surprised there wasn't any config value.
Would you be interesting in contributing to this? We can totally assist you with in questions and help through the process.
Places the work would involve:
- Updating the config: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/home/server/index.ts#L40 (so that we can disable before runtime)
- Updating https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/home/server/services/sample_data/sample_data_registry.ts#L69 to not host the route
- The Advanced Settings is the UI Settings (https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/home/server/ui_settings.ts#L19) it might be a little weird, potentially we can add an Advanced Setting then in the registry if the advanced setting is disabled, we don't install or we make the list dynamic which might be a little bit more work if it isn't already. The one thing I'm worried about is I think the API routes still will exist so the Advanced Setting will really serve not displaying in the UI. Where as the config will disable it completely.
Lemme know if you are interested and I can assign you to this ticket.
Hi, is there any option in OpenSearch Dashboards to disable the Add sample data for production environments? We have version 2.13.0 and I didn't find any option like that in the advanced settings of Dashboard Management.
A proposal, according to Josh Romero OpenSearch Dashboards maintainer via Slack channel: "That’s a good question… I was thinking it was maybe possible via the configuration file, but looking at the config for the home plugin (which handles the sample data service), it doesn’t look like there’s currently an option to disable: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/home/config.ts Adding such a toggle isn’t necessarily a huge amount of work, though, if you want to open an issue or PR."