search

opensearch-project / OpenSearch-Dashboards

📊 Open source visualization dashboards for OpenSearch.
https://opensearch.org/docs/latest/dashboards/index/
Apache License 2.0
1.6k stars 821 forks source link

[RFC] Data Source Tracking across Nav Changes #7171

Open derek-ho opened 5 days ago

derek-ho commented 5 days ago

Is your feature request related to a problem? Please describe. With new changes coming in with how navigation works in OSD core (See: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/7029), there is now an issue with tracking selected Data source globally (or even within the same sub-apps of a plugin).

Video of this problem occurring after breaking down in-app navigation into separate apps registered by OSD core:

https://github.com/opensearch-project/OpenSearch-Dashboards/assets/26328171/f7ff90b4-fb47-49db-ae9d-4c9171313c6f

A clear and concise description of what you want to happen.

When navigating between plugins or applications within a plugin, the datasource context is maintained.

A clear and concise description of any alternative solutions or features you've considered.

Instead of URL tracking datasources, we can use cookies (which would be persisted across apps), or we can have some globally managed data source (may introduce complexities with data source compatibility across workspaces/plugins).

Add any other context or screenshots about the feature request here.

derek-ho commented 5 days ago

@SuZhou-Joe can you take a look/any thoughts on this? I am happy to help out with a solution

derek-ho commented 5 days ago

Can a datasource be tracked per nav group/category instead?

SuZhou-Joe commented 5 days ago

Hi @derek-ho I will take a look on this.

SuZhou-Joe commented 5 days ago

https://github.com/opensearch-project/security-dashboards-plugin/pull/2022

Tagging related PR here.

SuZhou-Joe commented 4 days ago

Should be fixed by PR: https://github.com/derek-ho/security-dashboards-plugin/pull/3

derek-ho commented 3 days ago

Thanks @SuZhou-Joe. @BionIT since this issue was brought up a while ago: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/6534, what do you think of exposing a common URL (or even URL updater method) to standardize this behavior across all sub-applications and also different plugins within a nav category/group?