opensearch-project / OpenSearch-Dashboards

📊 Open source visualization dashboards for OpenSearch.
https://opensearch.org/docs/latest/dashboards/index/
Apache License 2.0
1.7k stars 898 forks source link

Fix SurroundingDocsView with URI encoded chars in document id #8869

Open smortex opened 1 week ago

smortex commented 1 week ago

When viewing surrounding documents of a document which id contains chars such as @ or +, these chars are encoded, preventing OpenSearch from finding the requested document.

Decode the id to transform back the URI encoded chars to the actual chars in the document id to find it and unbreak the feature.

Fixes #5711

Signed-off-by: Romain Tartière romain@blogreen.org

Changelog

github-actions[bot] commented 1 week ago

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

github-actions[bot] commented 1 week ago

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

github-actions[bot] commented 1 week ago

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.93%. Comparing base (413697d) to head (5c6f163). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8869 +/- ## ======================================= Coverage 60.93% 60.93% ======================================= Files 3800 3800 Lines 90878 90878 Branches 14323 14323 ======================================= Hits 55380 55380 Misses 31968 31968 Partials 3530 3530 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/8869/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [Linux_1](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/8869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `29.01% <ø> (ø)` | | | [Linux_2](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/8869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `56.39% <ø> (ø)` | | | [Linux_3](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/8869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `37.92% <ø> (ø)` | | | [Linux_4](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/8869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `29.00% <ø> (ø)` | | | [Windows_1](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/8869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `29.02% <ø> (ø)` | | | [Windows_2](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/8869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `56.34% <ø> (ø)` | | | [Windows_3](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/8869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `37.92% <ø> (ø)` | | | [Windows_4](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/8869/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `29.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.