opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
8.86k stars 1.62k forks source link

Update Cluster Manager Node Timeout to 3mins for flaky test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover #13505

Closed rahulkarajgikar closed 3 weeks ago

rahulkarajgikar commented 3 weeks ago

Description

Addresses fix for Flaky Test o.o.c.ClusterHealthIT.testHealthOnClusterManagerFailover which is caused in scenarios of master node not being able to bootup within 2 minutes occasionally

This change increases the time limit to 3 minutes which will reduce flakiness. In 5k runs with previous setting of 2 minutes, saw 5 failures. In 5k runs with new setting of 3 minutes, saw 0 failures

Related Issues

Resolves #1828

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 3 weeks ago

:white_check_mark: Gradle check result for bb5e9a451c5dbf73052e4768bfb13cafb4cd331e: SUCCESS

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.42%. Comparing base (b15cb0c) to head (bb5e9a4). Report is 262 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13505 +/- ## =========================================== Coverage 71.42% 71.42% - Complexity 59978 60957 +979 =========================================== Files 4985 5050 +65 Lines 282275 286805 +4530 Branches 40946 41552 +606 =========================================== + Hits 201603 204843 +3240 - Misses 63999 65049 +1050 - Partials 16673 16913 +240 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.