opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.

https://opensearch.org/docs/latest/opensearch/index/

Apache License 2.0

8.83k stars 1.62k forks source link

[Flaky test] Clear transient cluster setting at the end of the test #13508

Closed gbbafna closed 2 weeks ago

gbbafna commented 2 weeks ago

Description

Clear transient cluster setting at the end of the test to ensure test clean up doesn't fail

Remove check of non zero assertion of time as it is non deterministic

Related Issues

Resolves #11179 , #11221

Check List

[x] New functionality includes testing.
- [x] All tests pass
[ ] ~New functionality has been documented.~
- [ ] ~New functionality has javadoc added~
[ ] ~Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)~
[x] Commits are signed per the DCO using --signoff
[ ] ~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
[ ] ~Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for b580023eb5e18765ea98b0679e502f49ae734d64: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 0a40e2eefc1cc7876ae50b7529be6bf2de17871c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for b580023eb5e18765ea98b0679e502f49ae734d64: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

andrross commented 2 weeks ago

❌ Gradle check result for b580023: FAILURE

12639

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 0a40e2eefc1cc7876ae50b7529be6bf2de17871c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for b580023eb5e18765ea98b0679e502f49ae734d64: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

owaiskazi19 commented 2 weeks ago

@gbbafna looks like Spotless is complaining. Can you please format and push again?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 2f8ff1351413f2b574b6c0ef608ccf5a792d90d5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 2f8ff1351413f2b574b6c0ef608ccf5a792d90d5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 24d986cd81384afb5f366bd5e1bc2547c0066f6d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:grey_exclamation: Gradle check result for 24d986cd81384afb5f366bd5e1bc2547c0066f6d: UNSTABLE

TEST FAILURES:

  3 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.55%. Comparing base (b15cb0c) to head (24d986c). Report is 260 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #13508 +/- ## ============================================ + Coverage 71.42% 71.55% +0.13% - Complexity 59978 61086 +1108 ============================================ Files 4985 5051 +66 Lines 282275 287119 +4844 Branches 40946 41602 +656 ============================================ + Hits 201603 205452 +3849 - Misses 63999 64675 +676 - Partials 16673 16992 +319 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.