opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
8.83k stars 1.62k forks source link

Update TermsQueryBuilderTests to include TermQuery #13517

Closed harshavamsi closed 2 weeks ago

harshavamsi commented 2 weeks ago

Description

Quick follow up for #13480

Related Issues

Resolves #13480

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

:white_check_mark: Gradle check result for 22ca17c58028f340e023d6b1742e8bee70aa2f3f: SUCCESS

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.42%. Comparing base (b15cb0c) to head (22ca17c). Report is 256 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13517 +/- ## =========================================== Coverage 71.42% 71.42% - Complexity 59978 60973 +995 =========================================== Files 4985 5050 +65 Lines 282275 286865 +4590 Branches 40946 41571 +625 =========================================== + Hits 201603 204906 +3303 - Misses 63999 65007 +1008 - Partials 16673 16952 +279 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

opensearch-trigger-bot[bot] commented 2 weeks ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13517-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37df569367c5f57ee80785dbd446bd7ed7e49faa
# Push it to GitHub
git push --set-upstream origin backport/backport-13517-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13517-to-2.x.

VachaShah commented 2 weeks ago

@harshavamsi this needs a manual backport.