[Backport 2.x] Support multi ranges traversal when doing date histogram rewrite optimization (#13317) - Githubissues

opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.

https://opensearch.org/docs/latest/opensearch/index/

Apache License 2.0

8.83k stars 1.62k forks source link

[Backport 2.x] Support multi ranges traversal when doing date histogram rewrite optimization (#13317) #13522

Closed bowenlan-amzn closed 2 weeks ago

bowenlan-amzn commented 2 weeks ago

Description

Manual backport because auto backport failed https://github.com/opensearch-project/OpenSearch/pull/13317#issuecomment-2092036765

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

[ ] New functionality includes testing.
- [ ] All tests pass
[ ] New functionality has been documented.
- [ ] New functionality has javadoc added
[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 2d66adb083aab265dd8f0e6832e6cf8eefc50925: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for faf44dd4f59423c78441874567ef1767cefeae31: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for faf44dd4f59423c78441874567ef1767cefeae31: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 2d1e7f44fed191e1045f5083ed4f48330539b726: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for faf44dd4f59423c78441874567ef1767cefeae31: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for fdbbd834d6b7c5a0460b5b40548009640b0a62d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for fdbbd834d6b7c5a0460b5b40548009640b0a62d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for fdbbd834d6b7c5a0460b5b40548009640b0a62d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:white_check_mark: Gradle check result for fdbbd834d6b7c5a0460b5b40548009640b0a62d2: SUCCESS

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 82.65306% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 71.32%. Comparing base (0dd892c) to head (fdbbd83). Report is 229 commits behind head on 2.x.

Files	Patch %	Lines
...h/aggregations/bucket/FastFilterRewriteHelper.java	90.58%	6 Missing and 10 partials :warning:
.../bucket/histogram/AutoDateHistogramAggregator.java	22.22%	7 Missing :warning:
...egations/bucket/composite/CompositeAggregator.java	40.00%	6 Missing :warning:
...ions/bucket/histogram/DateHistogramAggregator.java	28.57%	5 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 2.x #13522 +/- ## ============================================ + Coverage 71.28% 71.32% +0.04% - Complexity 60145 61171 +1026 ============================================ Files 4957 5026 +69 Lines 282799 287653 +4854 Branches 41409 42058 +649 ============================================ + Hits 201591 205172 +3581 - Misses 64189 65166 +977 - Partials 17019 17315 +296 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

opensearch-trigger-bot[bot] commented 2 weeks ago

The backport to 2.14 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/backport-2.14
# Create a new branch
git switch --create backport/backport-13522-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab620026b7a0cc8d47a1327c2550680d4d6f132a
# Push it to GitHub
git push --set-upstream origin backport/backport-13522-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.14

Then, create a pull request where the base branch is 2.14 and the compare/head branch is backport/backport-13522-to-2.14.