DATETIME_FORMATTER_CACHING_SETTING experimental feature should not default to 'true'

opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.

https://opensearch.org/docs/latest/opensearch/index/

Apache License 2.0

8.83k stars 1.62k forks source link

DATETIME_FORMATTER_CACHING_SETTING experimental feature should not default to 'true' #13532

Closed reta closed 2 weeks ago

reta commented 2 weeks ago

Description

DATETIME_FORMATTER_CACHING_SETTING experimental feature should not default to 'true'

Related Issues

Closes https://github.com/opensearch-project/OpenSearch/issues/13411 (documentation update to follow shortly)

Check List

[X] New functionality includes testing.
- [X] All tests pass
[X] New functionality has been documented.
- [X] New functionality has javadoc added
[X] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[X] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for edb0cf8b5cb9d32ca0bd845d918e41402e5d0827: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 330dc558a25f28db530a149a38bfff50b4344d92: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for cfc808835468e157dc2c28a5ab1eb3da100d8b62: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta commented 2 weeks ago

❌ Gradle check result for cfc8088: FAILURE

https://github.com/opensearch-project/OpenSearch/issues/13473

reta commented 2 weeks ago

@andrross mind taking a look please? thank you!

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for cfc808835468e157dc2c28a5ab1eb3da100d8b62: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for cfc808835468e157dc2c28a5ab1eb3da100d8b62: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta commented 2 weeks ago

❌ Gradle check result for cfc8088: FAILURE

* What went wrong:
Execution failed for task ':plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestKeyStore'.
> process was found dead while waiting for ports files, node{:plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestKeyStore-0}

reta commented 2 weeks ago

❌ Gradle check result for cfc8088: FAILURE

https://github.com/opensearch-project/OpenSearch/issues/12685

github-actions[bot] commented 2 weeks ago

:grey_exclamation: Gradle check result for cfc808835468e157dc2c28a5ab1eb3da100d8b62: UNSTABLE

TEST FAILURES:

  1 org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting
  1 org.opensearch.index.ShardIndexingPressureSettingsIT.classMethod

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.54%. Comparing base (b15cb0c) to head (cfc8088). Report is 263 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #13532 +/- ## ============================================ + Coverage 71.42% 71.54% +0.11% - Complexity 59978 61092 +1114 ============================================ Files 4985 5052 +67 Lines 282275 287124 +4849 Branches 40946 41602 +656 ============================================ + Hits 201603 205409 +3806 - Misses 63999 64741 +742 - Partials 16673 16974 +301 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jed326 commented 1 week ago

Thanks @reta! I'm wondering if we should backport this to earlier versions as well (I think this was first introduced in 2.11)?

reta commented 1 week ago

Thanks @reta! I'm wondering if we should backport this to earlier versions as well (I think this was first introduced in 2.11)?

Thanks @jed326, I think we are not planing to release any patches for previous versions