opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
8.89k stars 1.63k forks source link

Adding distinct methods to identify whether the cluster state or data is remote-backed #13611

Open sulthan309 opened 3 weeks ago

sulthan309 commented 3 weeks ago

Description

Added new methods isRemoteDataNode and isRemoteClusterNode to identify remote data store or remote cluster.

Related Issues

Resolves #13523

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 3 weeks ago

:x: Gradle check result for e6c947c414d85754811f23a7549fd6c21b0ce907: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

BhumikaSaini-Amazon commented 3 weeks ago

Thanks @sulthan309 for the PR!

Please could you help resolve the failing build? The logs show that spotless checks are failing. You can resolve them using:

./gradlew :server:spotlessApply 

Please run precommit task to check for any other build failures:

./gradlew precommit

Also, please could you help add tests for your changes?

These guides would be helpful in understanding more:

  1. https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md (This also discusses the DCO requirement. Please add the DCO signoff on this PR.)
  2. https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md
  3. https://github.com/opensearch-project/OpenSearch/blob/main/TESTING.md

You can strike off the following items from the PR checklist:

Please take a look at the other checklist items.

Thanks!

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for aa8a57c6945614264338b70e0fd4bf01e02422b5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for e8d9561606a79d1b5f6df80e673506151a6235d6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?