[Tiered Caching] Additional ITs for cache stats

peteralfonsi commented 2 weeks ago

Description

Adds more ITs and UT coverage for cache stats in the tiered spillover cache. Also has 3 small bugfixes which were found during testing:

Cache clear API incorrectly wiped hits, misses, and eviction stats
Items evicted from the heap tier, but rejected from the disk tier due to policies, incorrectly weren't counted towards the total evictions for the cache
request_cache object in XContent response for the cache stats API was incorrectly at nodes.[node_id].request_cache instead of nodes.[node_id].caches.request_cache

Check List

[x] New functionality includes testing.
- [x] All tests pass
[x] New functionality has been documented.
- [x] New functionality has javadoc added ~- [N/A] API changes companion pull request created.~
[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff ~- [N/A] Commit changes are listed out in CHANGELOG.md file (See: Changelog)~ ~- [N/A] Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 5192014b7898ee5429aa9b7c6a007099f8414425: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 727f1a9e9d9f93eb88260f0c9c12f0e19c2f674c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for cd145bc76fd3775f09b66f8e4d6fd4a31734bcb1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:white_check_mark: Gradle check result for c365f301f7dab09478048638cba70682f4963f7e: SUCCESS

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.68%. Comparing base (b15cb0c) to head (d03988a). Report is 328 commits behind head on main.

:exclamation: Current head d03988a differs from pull request most recent head 4464fd9

Please upload reports for the commit 4464fd9 to get more accurate results.

Files	Patch %	Lines
...pensearch/common/cache/service/NodeCacheStats.java	0.00%	3 Missing :warning:
...e/common/tier/TieredSpilloverCacheStatsHolder.java	50.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #13655 +/- ## ============================================ + Coverage 71.42% 71.68% +0.26% - Complexity 59978 61363 +1385 ============================================ Files 4985 5064 +79 Lines 282275 288120 +5845 Branches 40946 41721 +775 ============================================ + Hits 201603 206545 +4942 - Misses 63999 64524 +525 - Partials 16673 17051 +378 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 54e396cbb88307644b598c90a3d379881e10b518: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dblock commented 2 weeks ago

❌ Gradle check result for 54e396c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.indices.IndicesRequestCacheIT.testStaleKeysCleanupWithMultipleIndices {p0={"search.concurrent_segment_search.enabled":"true"}}

https://github.com/opensearch-project/OpenSearch/issues/13437

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 54e396cbb88307644b598c90a3d379881e10b518: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 4 days ago

:x: Gradle check result for af5a9dc156a77baed0178122196c268f7a4be047: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 3 days ago

:x: Gradle check result for f12ec0fec276ea2295c01df376da07c0a1d8a2ec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 days ago

:x: Gradle check result for 08da71634523b9a2e5d45353672e533477233b26: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 days ago

:x: Gradle check result for 68607396a00ab3a6f6daa3456bcb31370157cf13: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 days ago

:x: Gradle check result for 90aa5fd16338764741b0b7bcc3f6663aa39efebd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 1 day ago

:grey_exclamation: Gradle check result for d03988a2d1b0dc00ab0ca4d100c5ae9010ecd214: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions[bot] commented 1 day ago

:x: Gradle check result for 4464fd9f95ee09862f665349b3bd9f2fcb3b16cc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

opensearch-project / OpenSearch