Open dblock opened 3 years ago
since i just ran into this issue:
But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.
where'd you see that code? i only see the explicit failure implemented here: https://github.com/opensearch-project/OpenSearch/blob/ae14259a2c4b9dcf203dc46ef217563a33ae2901/buildSrc/src/main/java/org/opensearch/gradle/docker/DockerSupportService.java#L153
Been a while since I wrote this TBH. I did a bit of searching and can't remember what I meant anymore :(
Is your feature request related to a problem? Please describe.
Coming from https://github.com/opensearch-project/OpenSearch/issues/1379, docker is required to build. But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.
Describe the solution you'd like
Skip
distribution:docker*
if docker is not available.Additional context
To reproduce, return
null
fromDockerSupportServices.java
,private Optional<String> getDockerPath()
or run on Windows.Current workaround: