Adds Integration Tests for Search Pipeline

opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.

https://opensearch.org/docs/latest/opensearch/index/

Apache License 2.0

9.84k stars 1.83k forks source link

Adds Integration Tests for Search Pipeline #16561

Closed owaiskazi19 closed 1 week ago

owaiskazi19 commented 2 weeks ago

Description

Adds Integration Tests for Search Pipeline

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

[x] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

owaiskazi19 commented 2 weeks ago

@msfroh @dbwiddis @saratvemulapalli can you take a look?

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 53ae28ad8f08505c1b90ffc697f60f8466ec2469: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:white_check_mark: Gradle check result for 98dfb5b1202a1c5cbce7873b456ac05abe05b6af: SUCCESS

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.12%. Comparing base (0363aa7) to head (160611f). Report is 17 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #16561 +/- ## ============================================ + Coverage 72.00% 72.12% +0.11% - Complexity 65038 65104 +66 ============================================ Files 5313 5313 Lines 303454 303469 +15 Branches 43910 43910 ============================================ + Hits 218510 218876 +366 + Misses 67040 66672 -368 - Partials 17904 17921 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

:white_check_mark: Gradle check result for 160611f55fa735aea7d33a789e2e8c26e574ebda: SUCCESS

owaiskazi19 commented 2 weeks ago

These tests are flexing core functionality (default pipelines, update configuration, etc). Do they belong in the integ tests for the search-pipeline-common module? Of course, testing that stuff from core is tricky, because there are no processors registered in core.

Do you think this is not the right place to add these tests? The reason you mentioned above was the sole reason I added it in search-pipeline-common.