Improve performance for resolving derived fields

robson-glean commented 2 weeks ago

Description

Doing the type check before the string comparison makes it much faster to resolve derived fields.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

[x] Functionality includes testing.
[x] API changes companion pull request created, if applicable.
[x] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

:grey_exclamation: Gradle check result for 83165ec9546ea6f6a985e42db9c79eee61cb5246: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.99%. Comparing base (0363aa7) to head (83165ec). Report is 6 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #16564 +/- ## ============================================ - Coverage 72.00% 71.99% -0.02% + Complexity 65038 65030 -8 ============================================ Files 5313 5313 Lines 303454 303469 +15 Branches 43910 43910 ============================================ - Hits 218510 218471 -39 - Misses 67040 67100 +60 + Partials 17904 17898 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

opensearch-project / OpenSearch