opensearch-project / OpenSearch

🔎 Open source distributed and RESTful search engine.
https://opensearch.org/docs/latest/opensearch/index/
Apache License 2.0
9.84k stars 1.83k forks source link

Fix non-x64 bwc build targets #16575

Closed andrross closed 2 weeks ago

andrross commented 2 weeks ago

There were a few issues here: the '-x64' suffix was being unconditionally appeneded, debian uses underscores not hyphens, and the rpm target uses the '.86_64' suffix.

This feels like a hack, but the ./gradlew distribution:bwc:minor:buildBwc task now succeeds with this commit, whereas previously several of the targets failed. I've tested this on Intel Linux, Arm Linux, and Apple Silicon Mac. I think during a normal check run only the target that corresponds to the platform doing the building is executed, which is why the other targets were broken but no one had noticed. I'll happily entertain any suggestions on how to add a test for this!

Related Issues

Resolves #16535

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

:x: Gradle check result for 31baa412758038c0924e508135707364139ab909: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] commented 2 weeks ago

:white_check_mark: Gradle check result for 31baa412758038c0924e508135707364139ab909: SUCCESS

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (0363aa7) to head (31baa41). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...e/internal/InternalDistributionBwcSetupPlugin.java 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16575 +/- ## ============================================ + Coverage 72.00% 72.08% +0.07% - Complexity 65038 65098 +60 ============================================ Files 5313 5314 +1 Lines 303454 303545 +91 Branches 43910 43923 +13 ============================================ + Hits 218510 218811 +301 + Misses 67040 66821 -219 - Partials 17904 17913 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.