Closed andrross closed 2 weeks ago
:x: Gradle check result for 31baa412758038c0924e508135707364139ab909: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?
:white_check_mark: Gradle check result for 31baa412758038c0924e508135707364139ab909: SUCCESS
Attention: Patch coverage is 0%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 72.08%. Comparing base (
0363aa7
) to head (31baa41
). Report is 9 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...e/internal/InternalDistributionBwcSetupPlugin.java | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There were a few issues here: the '-x64' suffix was being unconditionally appeneded, debian uses underscores not hyphens, and the rpm target uses the '.86_64' suffix.
This feels like a hack, but the
./gradlew distribution:bwc:minor:buildBwc
task now succeeds with this commit, whereas previously several of the targets failed. I've tested this on Intel Linux, Arm Linux, and Apple Silicon Mac. I think during a normalcheck
run only the target that corresponds to the platform doing the building is executed, which is why the other targets were broken but no one had noticed. I'll happily entertain any suggestions on how to add a test for this!Related Issues
Resolves #16535
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.